Add <!doctype html> to the to_html template - #5693
Merged
Merged
Conversation
23 tasks
emilykl
force-pushed
the
mishrakushal-add-doctype-to_html
branch
from
August 6, 2026 22:38
473f83a to
2e67205
Compare
emilykl
force-pushed
the
mishrakushal-add-doctype-to_html
branch
from
August 6, 2026 23:33
2e67205 to
0d0e641
Compare
emilykl
force-pushed
the
mishrakushal-add-doctype-to_html
branch
from
August 7, 2026 00:00
0d0e641 to
3cec990
Compare
camdecoster
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #4847
Continuation of PR #4848 by @mishrakushal
Description of change
Add
<!doctype html>at top of HTML template for compliance with modern web standards.Demo
n/a
Testing strategy
Call
fig.to_html()and verify that the generated HTML file has<!doctype html>at the very top.Additional information (optional)
Updated unit tests accordingly.
Note: Adding
<!doctype html>changed the chart rendering behaviour and made charts render at 450px high rather than filling the browser window. To keep the existing behaviour, this PR adds a small HTML snippet to the template:<style>html, body {{height: 100%;}}</style>Guidelines